highgate,
I know it is very, very difficult to quit smoking. Though not ideal, there has been some research that states that the nicotine gum is actually less "damaging" than smoking. Again, not ideal, but a little better. You might look into that.
The clicking is very common. It means the fracture still has not healed and is moving ever so slightly. Since it does not hurt a lot, that is a very good sign. The body has laid down some osteoid to make the bones "sticky", to glue them together. The body then comes in and calcifies the osteoid to make callus, the new bone formation.
Yes, as long as you have the clicking, shoulder motion may have to be delayed. As soon as you are allowed, start doing the pendulum exercises (Codman's). Some surgeons will even allow these will the patient is in a sling, but others are more conservative. So, always follow your surgeon's instructions.
The shoulder can get really stiff, so again, as soon as you are allowed, jump on the range of motion. You do not want to get a frozen shoulder.
With the elbow motion, one trick, is to hold your upper arm against your chest wall with your other hand. This will stabilize your fracture (keep brace on of course) while you are moving the elbow up and down. Remember to work on pronosupination (turning the palm up and down). You will sometimes notice the muscles in your upper arm contracting when you turn your palm up (supination). The biceps muscle is actually responsible for that motion.
TheraPutty is a putty like substance that occupational/hand therapists have their patients use to regain finger motion and forearm muscle strength. It comes in various firmnesses (which are color coded), from very, very soft with little resistance to very, very firm, almost like taffy.
It is used by just squeezing it. It allows full finger range of motion while strengthening the muscles in the forearm. As you get stronger, you change colors of TheraPutty, going to firmer and firmer ones.
You can ask your therapist about it. Many of them have tubs of it in their clinics. He/she should be able to get you some. Just do not drop it in the carpet, it is not play-dough, and it is tough to get it out of shag carpet (so I have heard).
So, again, if you can stop smoking, at least till the bone heals, that is the one best thing to do. The protein, calcium, vitamin D, magnesium, and other supplements are great. Work on finger, wrist, and elbow range of motion. You can use the putty to get grip strength. You can use light weights for wrist curls and rotations.
The more the distal joints/muscles have been worked toward being "normal", that is just that much less you have to worry about later.
Hang in there. You know from your previous injuries, this will take some work. Good luck.